linux-kernel - Re: [PATCH v1] MAINTAINERS: Sort entries in database for VSPRINTF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200211114508.zfvwpqgu5w2gzhwa@pathway.suse.cz>
Date:   Tue, 11 Feb 2020 12:45:08 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        linux-kernel@...r.kernel.org,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH v1] MAINTAINERS: Sort entries in database for VSPRINTF

On Mon 2020-02-10 16:51:29, Andy Shevchenko wrote:
> On Mon, Feb 10, 2020 at 03:21:55PM +0100, Petr Mladek wrote:
> > Hi Andy,
> > 
> > On Tue 2020-01-28 16:34:25, Andy Shevchenko wrote:
> > > Run parse-maintainers.pl and choose VSPRINTF record. Fix it accordingly.
> > 
> > Also the order does not look defined in the file. When I run
> > parse-maintainers.pl on the entire MAINTAINERS file:
> 
> See [2] for the details.
> 
> >  MAINTAINERS | 5584 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------
> >  1 file changed, 2787 insertions(+), 2797 deletions(-)
> > 
> > The file has 18545 lines. It means that huge amount of entries
> > do not follow the order.
> 
> Yes, but it's getting better.
> 
> [1]: 7683e9e52925 ("Properly alphabetize MAINTAINERS file")
> [2]: https://lore.kernel.org/lkml/CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@mail.gmail.com/

Ok, the message [2] is Linus' reaction on a similar patch.
He complained that

 (a) the ordering wasn't complete
 (b) this wasn't scripted.

In fact, parse-maintainers.pl was created to automatize such clean ups
and allow to fix all entries at once.

Fixing only VSPRITF record is a tiny-piece-by-piece approach.
It is an approach that will create a lot of work for many people.

If you want to do a clean up then please ask Linus to do it by the
script.

Also please add a check into checkpatch.pl to reduce regressions.

Best Regards,
Petr