linux-kernel - Re: [PATCH] firmware/dmi: Report DMI Bios & EC firmware release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba5b88c9-f056-9375-d1fb-7832c76db29f@criteo.com>
Date:   Tue, 11 Feb 2020 14:31:29 +0100
From:   Erwan Velu <e.velu@...teo.com>
To:     Jean Delvare <jdelvare@...e.de>,
        Erwan Velu <erwanaliasr1@...il.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Mattias Jacobsson <2pi@....nu>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Andrew Lunn <andrew@...n.ch>,
        "Darren Hart (VMware)" <dvhart@...radead.org>,
        Changbin Du <changbin.du@...el.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] firmware/dmi: Report DMI Bios & EC firmware release

No issue with that.

Thanks for applying.

Erwan,

On 11/02/2020 14:21, Jean Delvare wrote:
> On Fri,  7 Feb 2020 09:35:47 +0100, Erwan Velu wrote:
>> Some vendors like HPe or Dell, encode the release version of their BIOS
>> in the "System BIOS {Major|Minor} Release" fields of Type 0.
>>
>> This information is used to know which bios release actually runs.
>> It could be used for some quirks, debugging sessions or inventory tasks.
>>
>> A typical output for a Dell system running the 65.27 bios is :
>> 	[root@...00 ~]# cat /sys/devices/virtual/dmi/id/bios_release
>> 	65.27
>> 	[root@...00 ~]#
>>
>> Servers that have a BMC encode the release version of their firmware in the
>>   "Embedded Controller Firmware {Major|Minor} Release" fields of Type 0.
>>
>> This information is used to know which BMC release actually runs.
>> It could be used for some quirks, debugging sessions or inventory tasks.
>>
>> A typical output for a Dell system running the 3.75 bmc release is :
>>      [root@...00 ~]# cat /sys/devices/virtual/dmi/id/ec_firmware_release
>>      3.75
>>      [root@...00 ~]#
>>
>> Signed-off-by: Erwan Velu <e.velu@...teo.com>
>> ---
>>   drivers/firmware/dmi-id.c       |  6 ++++++
>>   drivers/firmware/dmi_scan.c     | 30 ++++++++++++++++++++++++++++++
>>   include/linux/mod_devicetable.h |  2 ++
>>   scripts/mod/file2alias.c        |  2 ++
>>   4 files changed, 40 insertions(+)
>> (...)
> Applied, thanks. Note that I went for "efr" as the shortcut string for
> DMI_EC_FIRMWARE_RELEASE, which was your first choice and has my
> preference.
>