linux-kernel - Re: [PATCH v2 11/12] drm/i915/hdmi: convert to struct drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tv3xz156.fsf@intel.com>
Date:   Tue, 11 Feb 2020 15:47:33 +0200
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Wambui Karuga <wambui.karugax@...il.com>,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        airlied@...ux.ie, daniel@...ll.ch
Cc:     sean@...rly.run, intel-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 11/12] drm/i915/hdmi: convert to struct drm_device based logging macros.

On Thu, 06 Feb 2020, Wambui Karuga <wambui.karugax@...il.com> wrote:
> @@ -1364,11 +1372,15 @@ int intel_hdmi_hdcp_write_an_aksv(struct intel_digital_port *intel_dig_port,
>  static int intel_hdmi_hdcp_read_bksv(struct intel_digital_port *intel_dig_port,
>  				     u8 *bksv)
>  {
> +	struct drm_i915_private *i915 =
> +		intel_dig_port->base.base.dev->dev_private;

The preferred way to get from intel_digital_port to i915 throughout is

	struct drm_i915_private *i915 = to_i915(intel_dig_port->base.base.dev);

I realize there are some bad examples in the file; I've posted [1] to
fix them.

BR,
Jani.


[1] http://patchwork.freedesktop.org/patch/msgid/20200211134427.31605-1-jani.nikula@intel.com

-- 
Jani Nikula, Intel Open Source Graphics Center