linux-kernel - Re: [PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85f21dab-b0eb-c416-3434-9a10a00d7f77@huawei.com>
Date:   Tue, 11 Feb 2020 22:28:12 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     <nsaenzjulienne@...e.de>, <gregkh@...uxfoundation.org>,
        <wahrenst@....net>, <jamal.k.shareef@...il.com>,
        <marcgonzalez@...gle.com>, <nishkadg.linux@...il.com>,
        <nachukannan@...il.com>, <devel@...verdev.osuosl.org>,
        <linux-kernel@...r.kernel.org>,
        <bcm-kernel-feedback-list@...adcom.com>,
        <linux-rpi-kernel@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -next] staging: vc04_services: remove set but unused
 variable 'local_entity_uc'

On 2020/2/11 22:24, Dan Carpenter wrote:
> On Tue, Feb 11, 2020 at 09:43:56PM +0800, YueHaibing wrote:
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function vchiq_use_internal:
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2346:16:
>>  warning: variable local_entity_uc set but not used [-Wunused-but-set-variable]
>>
>> commit bd8aa2850f00 ("staging: vc04_services: Get of even more suspend/resume states")
>> left behind this unused variable.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> index c456ced..d30d24d 100644
>> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>> @@ -2343,7 +2343,7 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
>>  	enum vchiq_status ret = VCHIQ_SUCCESS;
>>  	char entity[16];
>>  	int *entity_uc;
>> -	int local_uc, local_entity_uc;
>> +	int local_uc;
>>  
>>  	if (!arm_state)
>>  		goto out;
>> @@ -2367,7 +2367,6 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
>>  
>>  	write_lock_bh(&arm_state->susp_res_lock);
>>  	local_uc = ++arm_state->videocore_use_count;
>> -	local_entity_uc = ++(*entity_uc);
>                           ^^
> This ++ is required.

oops..., Thanks!

> 
> regards,
> dan carpenter
> 
> 
> .
>