[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200211142947.favkq56gkyexqkpg@pathway.suse.cz>
Date: Tue, 11 Feb 2020 15:29:47 +0100
From: Petr Mladek <pmladek@...e.com>
To: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/3] printk: Move console matching logic into a
separate function
On Thu 2020-02-06 15:02:18, Benjamin Herrenschmidt wrote:
> This moves the loop that tries to match a newly registered console
> with the command line or add_preferred_console list into a separate
> helper, in order to be able to call it multiple times in subsequent
> patches.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Looks fine to me.
Reviewed-by: Petr Mladek <pmladek@...e.com>
Just few nits below.
> @@ -2626,6 +2627,60 @@ static int __init keep_bootcon_setup(char *str)
> + /*
> + * Some consoles, such as pstore and netconsole, can be enabled even
> + * without matching.
> + */
There are few lines in the patchset where the indentation is done
by spaces instead of tabs. The above 3 lines are just one example.
I'll fix this when pushing. But please, be more careful next time ;-)
I suggest to use some more clever editor that helps with code
formatting.
Also I suggest to run ./scripts/checkpatch.pl on the patches
before sending.
Also the three patches were not send in a single thread so that
it was harder to find all the pieces. I personally use:
git format-patch --cover-letter origin/master -o some-dir
./scripts/checkpatch.pl some-dir/*
$> edit some-dir/0000-*.patch
git send-email --smtp-server=... --to= --cc= ... some-dir/*
Best Regards,
Petr
Powered by blists - more mailing lists