linux-kernel - Re: [PATCH] Removing a duplicate condition.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+0WNHWR9P4062gjP7Ow0aPaccMzP=AK3-DjQ9FDf9UfA@mail.gmail.com>
Date:   Tue, 11 Feb 2020 07:08:26 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Isaac Young <isaac.young5@...il.com>
Cc:     Shuah Khan <shuah@...nel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Removing a duplicate condition.

On Tue, Feb 11, 2020 at 5:26 AM Isaac Young <isaac.young5@...il.com> wrote:
>
> Signed-off-by: Isaac Young <isaac.young5@...il.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/select_reuseport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> index 098bcae5f827..0954c7a8aa08 100644
> --- a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> +++ b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> @@ -823,7 +823,7 @@ void test_select_reuseport(void)
>
>         saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
>         saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
> -       if (saved_tcp_syncookie < 0 || saved_tcp_syncookie < 0)
> +       if (saved_tcp_syncookie < 0)
>                 goto out;

please resend this patch to bpf@...r and cc maintainers.
Also see bpf_devel_QA.rst
Thanks