linux-kernel - Re: [PATCH -next] staging: wfx: remove set but not used variable 'tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7641155.kNzuLtrjOU@pc-42>
Date:   Tue, 11 Feb 2020 15:21:41 +0000
From:   Jérôme Pouiller <Jerome.Pouiller@...abs.com>
To:     YueHaibing <yuehaibing@...wei.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] staging: wfx: remove set but not used variable
 'tx_priv'

On Tuesday 11 February 2020 15:03:34 CET YueHaibing wrote:
> drivers/staging/wfx/queue.c: In function wfx_tx_queues_get:
> drivers/staging/wfx/queue.c:484:28: warning: variable tx_priv set but not used [-Wunused-but-set-variable]
> 
> commit 2e57865e79cf ("staging: wfx: pspoll_mask make no sense")
> left behind this unused variable.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/staging/wfx/queue.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
> index 0bcc61f..c73d158 100644
> --- a/drivers/staging/wfx/queue.c
> +++ b/drivers/staging/wfx/queue.c
> @@ -481,7 +481,6 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
>         struct wfx_queue *vif_queue = NULL;
>         u32 tx_allowed_mask = 0;
>         u32 vif_tx_allowed_mask = 0;
> -       const struct wfx_tx_priv *tx_priv = NULL;
>         struct wfx_vif *wvif;
>         int not_found;
>         int burst;
> @@ -541,7 +540,6 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
>                 skb = wfx_tx_queue_get(wdev, queue, tx_allowed_mask);
>                 if (!skb)
>                         continue;
> -               tx_priv = wfx_skb_tx_priv(skb);
>                 hif = (struct hif_msg *) skb->data;
>                 wvif = wdev_to_wvif(wdev, hif->interface);
>                 WARN_ON(!wvif);
> --
> 2.7.4

Reviewed-by: Jérôme Pouiller <jerome.pouiller@...abs.com>

-- 
Jérôme Pouiller