linux-kernel - Re: [PATCH -next] dmaengine: idxd: remove set but not used variable 'group'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <397d824a-8827-c5b8-4dda-60fe79c6512d@intel.com>
Date:   Tue, 11 Feb 2020 09:14:08 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     YueHaibing <yuehaibing@...wei.com>, dan.j.williams@...el.com,
        vkoul@...nel.org
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] dmaengine: idxd: remove set but not used variable
 'group'



On 2/11/20 6:53 AM, YueHaibing wrote:
> drivers/dma/idxd/sysfs.c: In function engine_group_id_store:
> drivers/dma/idxd/sysfs.c:419:29: warning: variable group set but not used [-Wunused-but-set-variable]
> 
> It is not used, so remove it.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Dave Jiang <dave.jiang@...el.com>

> ---
>   drivers/dma/idxd/sysfs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
> index 6d907fe..e4f35bd 100644
> --- a/drivers/dma/idxd/sysfs.c
> +++ b/drivers/dma/idxd/sysfs.c
> @@ -416,7 +416,7 @@ static ssize_t engine_group_id_store(struct device *dev,
>   	struct idxd_device *idxd = engine->idxd;
>   	long id;
>   	int rc;
> -	struct idxd_group *prevg, *group;
> +	struct idxd_group *prevg;
>   
>   	rc = kstrtol(buf, 10, &id);
>   	if (rc < 0)
> @@ -436,7 +436,6 @@ static ssize_t engine_group_id_store(struct device *dev,
>   		return count;
>   	}
>   
> -	group = &idxd->groups[id];
>   	prevg = engine->group;
>   
>   	if (prevg)
>