linux-kernel - Re: [PATCH 1/1] usb: Add MA USB Host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Feb 2020 08:41:08 -0800
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Vladimir Stankovic <vladimir.stankovic@...playlink.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Petar Kovacevic <petar.kovacevic@...playlink.com>,
        Stefan Lugonjic <stefan.lugonjic@...playlink.com>,
        Nikola Simic <nikola.simic@...playlink.com>,
        Marko Miljkovic <marko.miljkovic@...playlink.com>
Subject: Re: [PATCH 1/1] usb: Add MA USB Host driver

On Tue, Feb 11, 2020 at 04:21:24PM +0000, Vladimir Stankovic wrote:
> +++ b/drivers/usb/mausb_host/include/common/ma_usb.h
> @@ -0,0 +1,873 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Nice.

> +/*
> + * Copyright (c) 2019 - 2020 DisplayLink (UK) Ltd.
> + *
> + * This file is subject to the terms and conditions of the GNU General Public
> + * License v2. See the file COPYING in the main directory of this archive for
> + * more details.

Note, COPYING does not say what you think it says here :)

Please remove all "license boilerplate" from all of these files, with
the use of SPDX you do not need it, and, as is the case here, it can
often be wrong.

thanks,

greg k-h