[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e8c2b347-5af2-e48c-0f9d-2a6860171171@roeck-us.net>
Date: Mon, 10 Feb 2020 18:30:46 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Chris Packham <Chris.Packham@...iedtelesis.co.nz>,
"guillaume.ligneul@...il.com" <guillaume.ligneul@...il.com>,
Henry Shen <Henry.Shen@...iedtelesis.co.nz>,
"jdelvare@...e.com" <jdelvare@...e.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH] hwmon: (lm73) Add support for of_match_table
On 2/10/20 6:21 PM, Chris Packham wrote:
> On Wed, 2020-02-05 at 14:06 +1300, Henry Shen wrote:
>> Add the of_match_table.
>
> Needs your Signed-off-by line.
>
ti,lm73 would also have to be documented as trivial device.
Guenter
>> ---
>> drivers/hwmon/lm73.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/hwmon/lm73.c b/drivers/hwmon/lm73.c
>> index 1eeb9d7de2a0..733c48bf6c98 100644
>> --- a/drivers/hwmon/lm73.c
>> +++ b/drivers/hwmon/lm73.c
>> @@ -262,10 +262,20 @@ static int lm73_detect(struct i2c_client *new_client,
>> return 0;
>> }
>>
>> +static const struct of_device_id lm73_of_match[] = {
>> + {
>> + .compatible = "ti,lm73",
>> + },
>> + { },
>> +};
>> +
>> +MODULE_DEVICE_TABLE(of, lm73_of_match);
>> +
>> static struct i2c_driver lm73_driver = {
>> .class = I2C_CLASS_HWMON,
>> .driver = {
>> .name = "lm73",
>> + .of_match_table = lm73_of_match,
>> },
>> .probe = lm73_probe,
>> .id_table = lm73_ids,
Powered by blists - more mailing lists