linux-kernel - Re: [PATCH] powerpc/time: Replace <linux/clk-provider.h> by <linux/of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <158152704814.121156.18379102281375554988@swboyd.mtv.corp.google.com>
Date:   Wed, 12 Feb 2020 09:04:08 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Michael Ellerman <mpe@...erman.id.au>,
        Paul Mackerras <paulus@...ba.org>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] powerpc/time: Replace <linux/clk-provider.h> by <linux/of_clk.h>

Quoting Geert Uytterhoeven (2020-02-12 02:17:36)
> The PowerPC time code is not a clock provider, and just needs to call
> of_clk_init().
> 
> Hence it can include <linux/of_clk.h> instead of <linux/clk-provider.h>.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---

Reviewed-by: Stephen Boyd <sboyd@...nel.org>

This has an ifdef around the of_clk_init() call. Can you remove that too
given that we stub it out in the header?