linux-kernel - Re: Linux 5.6-rc1 kselftest build failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5311f218-9bb0-4792-c469-019c7c2db7ee@kernel.org>
Date:   Wed, 12 Feb 2020 10:38:05 -0700
From:   shuah <shuah@...nel.org>
To:     Aleksa Sarai <cyphar@...har.com>
Cc:     linux-kselftest@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dmitry Safonov <dima@...sta.com>, shuah <shuah@...nel.org>
Subject: Re: Linux 5.6-rc1 kselftest build failures

On 2/12/20 1:14 AM, Aleksa Sarai wrote:
> On 2020-02-11, shuah <shuah@...nel.org> wrote:
>> openat2:
>>
>> tools/testing/selftests/openat2'
>> gcc -Wall -O2 -g -fsanitize=address -fsanitize=undefined openat2_test.c
>> helpers.c  -o tools/testing/selftests/openat2/openat2_test
>> In file included from /usr/include/fcntl.h:301,
>>                   from helpers.c:9:
>> In function ‘openat’,
>>      inlined from ‘touchat’ at helpers.c:49:11:
>> /usr/include/x86_64-linux-gnu/bits/fcntl2.h:126:4: error: call to
>> ‘__openat_missing_mode’ declared with attribute error: openat with O_CREAT
>> or O_TMPFILE in third argument needs 4 arguments
>>    126 |    __openat_missing_mode ();
>>        |    ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> Yeah, that's a brain-o -- it looks like you have a newer glibc than
> me which gives you a warning when you don't set the mode. The fix should
> be just the following:
> 

Nice. Do you mind sending a proper patch, I can pull in.

thanks,
-- Shuah