linux-kernel - Re: [PATCH v2 3/4] clk: Move rate and accuracy recalc to mostly consumer APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <158155009817.184098.11949016504276688949@swboyd.mtv.corp.google.com>
Date:   Wed, 12 Feb 2020 15:28:18 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Jerome Brunet <jbrunet@...libre.com>
Subject: Re: [PATCH v2 3/4] clk: Move rate and accuracy recalc to mostly consumer APIs

Quoting Stephen Boyd (2020-02-05 15:28:01)
> There's some confusion about when recalc is done for the rate and
> accuracy clk consumer APIs in relation to the prepare lock being taken.
> Oddly enough, we take the lock again in debugfs APIs so that we can call
> the internal "clk_core" APIs to get these fields with any necessary
> recalculations. Instead of having this confusion, let's introduce a
> recalc variant of these two consumer APIs as internal helpers and call
> them from the consumer APIs and the debugfs code so that we don't take
> the lock more than once.
> 
> Cc: Douglas Anderson <dianders@...omium.org>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: Jerome Brunet <jbrunet@...libre.com>
> Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> ---

Applied to clk-next