linux-kernel - Re: [PATCH v7 2/2] fpga: dfl: fme: add performance reporting support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200212053035.GA382718@kroah.com>
Date:   Tue, 11 Feb 2020 21:30:35 -0800
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Wu Hao <hao.wu@...el.com>
Cc:     Will Deacon <will@...nel.org>, mdf@...nel.org,
        mark.rutland@....com, linux-fpga@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        atull@...nel.org, yilun.xu@...el.com,
        Luwei Kang <luwei.kang@...el.com>
Subject: Re: [PATCH v7 2/2] fpga: dfl: fme: add performance reporting support

On Wed, Feb 12, 2020 at 11:19:29AM +0800, Wu Hao wrote:
> On Mon, Feb 10, 2020 at 04:34:01PM +0000, Will Deacon wrote:
> > Hi,
> > 
> > On Mon, Feb 10, 2020 at 11:47:49AM +0800, Wu Hao wrote:
> > > This patch adds support for performance reporting private feature
> > > for FPGA Management Engine (FME). Now it supports several different
> > > performance counters, including 'basic', 'cache', 'fabric', 'vtd'
> > > and 'vtd_sip'. It allows user to use standard linux tools to access
> > > these performance counters.
> > 
> > I had a quick look at this, and it mostly looks alright to me. Just a few
> > high-level comments/questions:
> 
> Hi Will
> 
> Thanks a lot for the review! :)
> 
> > 
> >   - I would still prefer for the PMU drivers to live under drivers/perf/
> 
> Hm.. one possible way is to create a platform device, and introduce a new
> platform device driver under drivers/perf/.

No, do not abuse platform drivers, you have a real device, use it.