linux-kernel - Re: [PATCH] soc: qcom: aoss: Use wake_up_all() instead of wake_up_interruptible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200212063154.GO3948@builder>
Date:   Tue, 11 Feb 2020 22:31:54 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Arun Kumar Neelakantam <aneela@...eaurora.org>
Cc:     clew@...eaurora.org, Andy Gross <agross@...nel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: qcom: aoss: Use wake_up_all() instead of
 wake_up_interruptible_all()

On Wed 22 Jan 00:23 PST 2020, Arun Kumar Neelakantam wrote:

> During the probe the task is waiting in TASK_UNINTERRUPTIBLE state which
> cannot be woken-up by wake_up_interruptible_all() function.
> 
> Use wake_up_all() to wake-up both TASK_UNINTERRUPTIBLE and
> TASK_INTERRUPTIBLE state tasks.
> 
> Signed-off-by: Arun Kumar Neelakantam <aneela@...eaurora.org>

Applied

Regards,
Bjorn

> ---
>  drivers/soc/qcom/qcom_aoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
> index 006ac40..fe79661 100644
> --- a/drivers/soc/qcom/qcom_aoss.c
> +++ b/drivers/soc/qcom/qcom_aoss.c
> @@ -200,7 +200,7 @@ static irqreturn_t qmp_intr(int irq, void *data)
>  {
>  	struct qmp *qmp = data;
>  
> -	wake_up_interruptible_all(&qmp->event);
> +	wake_up_all(&qmp->event);
>  
>  	return IRQ_HANDLED;
>  }
> -- 
> 1.9.1