lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Feb 2020 10:31:33 +0900 From: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> To: Petr Mladek <pmladek@...e.com> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org> Subject: Re: [PATCH v1] printk: Declare log_wait as external variable On (20/02/11 13:43), Petr Mladek wrote: > > Even better solution might be to move fs/proc/kmsg.c to > kernel/printk/proc_kmsg.c and declare printk_log_wait only > in kernel/printk/internal.h. I think that this is what > Sergey suggested. Yes, right. > Another great thing would be to extract devkmsg stuff from > kernel/printk/printk.c and put it into kernel/printk/dev_kmsg.c. Yeah, can do, I would still prefer proc_kmsg to "move in". Either both can live in printk.c (won't make it much worse), or in kernel/printk/dev_kmsg.c and kernel/printk/proc_kmsg.c I can take a look at dev_ksmg.c/proc_kmsg.c option, unless someone else wants to spend their time on this. -ss
Powered by blists - more mailing lists