linux-kernel - Re: [PATCH v2] asm-generic: Fix unistd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dacfbf2c-74b3-3d52-1fdd-d757b4a19c73@xilinx.com>
Date:   Wed, 12 Feb 2020 10:26:22 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Max Filippov <jcmvbkbc@...il.com>,
        Michal Simek <michal.simek@...inx.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Michal Simek <monstr@...str.eu>, git@...inx.com,
        Arnd Bergmann <arnd@...db.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stefan Asserhall <stefan.asserhall@...inx.com>,
        Chris Zankel <chris@...kel.net>,
        "David S. Miller" <davem@...emloft.net>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Helge Deller <deller@....de>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Matt Turner <mattst88@...il.com>,
        Rich Felker <dalias@...c.org>,
        Richard Henderson <rth@...ddle.net>,
        Tony Luck <tony.luck@...el.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        "open list:ALPHA PORT" <linux-alpha@...r.kernel.org>,
        "open list:IA64 (Itanium) PL..." <linux-ia64@...r.kernel.org>,
        "open list:M68K ARCHITECTURE" <linux-m68k@...ts.linux-m68k.org>,
        "open list:PARISC ARCHITECTURE" <linux-parisc@...r.kernel.org>,
        "open list:SUPERH" <linux-sh@...r.kernel.org>,
        "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@...ux-xtensa.org>,
        "open list:SPARC + UltraSPAR..." <sparclinux@...r.kernel.org>
Subject: Re: [PATCH v2] asm-generic: Fix unistd_32.h generation format

On 12. 02. 20 10:23, Max Filippov wrote:
> On Wed, Feb 12, 2020 at 1:16 AM Michal Simek <michal.simek@...inx.com> wrote:
>>
>> Generated files are also checked by sparse that's why add newline
>> to remove sparse (C=1) warning.
>>
>> The issue was found on Microblaze and reported like this:
>> ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
>> warning: no newline at end of file
>>
>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
>> Reviewed-by: Stefan Asserhall <stefan.asserhall@...inx.com>
>> ---
>>
>> Changes in v2:
>> - Update also others archs not just microblaze - Arnd
>> - Align subject and description to match multiarch chagne
>>
>>  arch/alpha/kernel/syscalls/syscallhdr.sh      | 1 +
>>  arch/ia64/kernel/syscalls/syscallhdr.sh       | 1 +
>>  arch/m68k/kernel/syscalls/syscallhdr.sh       | 1 +
>>  arch/microblaze/kernel/syscalls/syscallhdr.sh | 1 +
>>  arch/parisc/kernel/syscalls/syscallhdr.sh     | 1 +
>>  arch/sh/kernel/syscalls/syscallhdr.sh         | 1 +
>>  arch/sparc/kernel/syscalls/syscallhdr.sh      | 1 +
>>  arch/xtensa/kernel/syscalls/syscallhdr.sh     | 1 +
>>  8 files changed, 8 insertions(+)
> 
> For xtensa:
> Acked-by: Max Filippov <jcmvbkbc@...il.com>
> 
> ...
> 
>> diff --git a/arch/m68k/kernel/syscalls/syscallhdr.sh b/arch/m68k/kernel/syscalls/syscallhdr.sh
>> index 6f357d68ef44..8ac15be01ac2 100644
>> --- a/arch/m68k/kernel/syscalls/syscallhdr.sh
>> +++ b/arch/m68k/kernel/syscalls/syscallhdr.sh
>> @@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
>>         printf "#endif\n"
>>         printf "\n"
>>         printf "#endif /* %s */\n" "${fileguard}"
> 
> Here there's already \n at the end, so no need for another one?

No it is not needed. But I think that make sense to have the same
solution in all these scripts. Above printf is adding newline that's why
I have used the same style.

M