linux-kernel - Re: [PATCH] lib: Use kzalloc() instead of kmalloc() with flag GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Feb 2020 10:56:16 +0100
From:   Alexander Potapenko <glider@...gle.com>
To:     Yi Wang <wang.yi59@....com.cn>
Cc:     Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Dmitriy Vyukov <dvyukov@...gle.com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        LKML <linux-kernel@...r.kernel.org>, xue.zhihong@....com.cn,
        wang.liang82@....com.cn, Huang Zijiang <huang.zijiang@....com.cn>
Subject: Re: [PATCH] lib: Use kzalloc() instead of kmalloc() with flag GFP_ZERO.

On Wed, Feb 12, 2020 at 10:54 AM Yi Wang <wang.yi59@....com.cn> wrote:
>
> From: Huang Zijiang <huang.zijiang@....com.cn>
>
> Use kzalloc instead of manually setting kmalloc
> with flag GFP_ZERO since kzalloc sets allocated memory
> to zero.
>
> Change in v2:
>     add indation
>
> Signed-off-by: Huang Zijiang <huang.zijiang@....com.cn>
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>
Reviewed-by: Alexander Potapenko <glider@...gle.com>
> ---
>  lib/test_kasan.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index 328d33b..79be158 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -599,7 +599,7 @@ static noinline void __init kasan_memchr(void)
>         size_t size = 24;
>
>         pr_info("out-of-bounds in memchr\n");
> -       ptr = kmalloc(size, GFP_KERNEL | __GFP_ZERO);
> +       ptr = kzalloc(size, GFP_KERNEL);
>         if (!ptr)
>                 return;
>
> @@ -614,7 +614,7 @@ static noinline void __init kasan_memcmp(void)
>         int arr[9];
>
>         pr_info("out-of-bounds in memcmp\n");
> -       ptr = kmalloc(size, GFP_KERNEL | __GFP_ZERO);
> +       ptr = kzalloc(size, GFP_KERNEL);
>         if (!ptr)
>                 return;
>
> @@ -629,7 +629,7 @@ static noinline void __init kasan_strings(void)
>         size_t size = 24;
>
>         pr_info("use-after-free in strchr\n");
> -       ptr = kmalloc(size, GFP_KERNEL | __GFP_ZERO);
> +       ptr = kzalloc(size, GFP_KERNEL);
>         if (!ptr)
>                 return;
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/1581501228-5393-1-git-send-email-wang.yi59%40zte.com.cn.



-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg