linux-kernel - Re: [RESEND,v2,1/1] arm: dts: mediatek: add mt7629 pwm support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Feb 2020 11:15:37 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Sam Shih <sam.shih@...iatek.com>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [RESEND,v2,1/1] arm: dts: mediatek: add mt7629 pwm support



On 12/02/2020 03:35, Sam Shih wrote:
> This adds pwm support for MT7629.

The information below should not be part of the commit message, the next time
please put it below the line "---".

> Used:
> https://patchwork.kernel.org/patch/11160851/
> 
> Change since v1:
> remove unused property num-pwm
> 
> Signed-off-by: Sam Shih <sam.shih@...iatek.com>
> ---
>  arch/arm/boot/dts/mt7629.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi
> index 867b88103b9d..ce2a30a24017 100644
> --- a/arch/arm/boot/dts/mt7629.dtsi
> +++ b/arch/arm/boot/dts/mt7629.dtsi
> @@ -241,6 +241,20 @@
>  			status = "disabled";
>  		};
>  
> +		pwm: pwm@...06000 {
> +			compatible = "mediatek,mt7629-pwm";
> +			reg = <0x11006000 0x1000>;
> +			interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>;
> +			clocks = <&topckgen CLK_TOP_PWM_SEL>,
> +				 <&pericfg CLK_PERI_PWM_PD>,
> +				 <&pericfg CLK_PERI_PWM1_PD>;
> +			clock-names = "top", "main", "pwm1";
> +			assigned-clocks = <&topckgen CLK_TOP_PWM_SEL>;
> +			assigned-clock-parents =
> +					<&topckgen CLK_TOP_UNIVPLL2_D4>;
> +			status = "disabled";
> +		};
> +

This does not match the binding description.
Please fix that.


>  		i2c: i2c@...07000 {
>  			compatible = "mediatek,mt7629-i2c",
>  				     "mediatek,mt2712-i2c";
>