linux-kernel - Re: [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Feb 2020 13:02:16 +0200
From:   Oleksandr Suvorov <cryosay@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Mark Rutland <mark.rutland@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sanchayan Maity <maitysanchayan@...il.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>
Subject: Re: [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties

On Wed, Feb 12, 2020 at 12:46 PM Johan Hovold <johan@...nel.org> wrote:
>
> The sram-node compatible properties have mistakingly combined the
> model-specific string with the generic "mtd-ram" string.
>
> Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or
> "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are
> not present in any binding.
>
> The physmap driver will however bind to platform devices that specify
> "mtd-ram".
>
> Fixes: fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
> Cc: Sanchayan Maity <maitysanchayan@...il.com>
> Cc: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>

> ---
>  arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> index cd075621de52..84fcc203a2e4 100644
> --- a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> @@ -275,7 +275,7 @@ &weim {
>
>         /* SRAM on Colibri nEXT_CS0 */
>         sram@0,0 {
> -               compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> +               compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
>                 reg = <0 0 0x00010000>;
>                 #address-cells = <1>;
>                 #size-cells = <1>;
> @@ -286,7 +286,7 @@ sram@0,0 {
>
>         /* SRAM on Colibri nEXT_CS1 */
>         sram@1,0 {
> -               compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> +               compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
>                 reg = <1 0 0x00010000>;
>                 #address-cells = <1>;
>                 #size-cells = <1>;
> --
> 2.24.1
>


--
Best regards

Oleksandr Suvorov
cryosay@...il.com