lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Feb 2020 12:45:04 +0100 From: Paolo Bonzini <pbonzini@...hat.com> To: Krish Sadhukhan <krish.sadhukhan@...cle.com>, Eric Auger <eric.auger@...hat.com>, eric.auger.pro@...il.com, linux-kernel@...r.kernel.org, kvm@...r.kernel.org, vkuznets@...hat.com Cc: thuth@...hat.com, drjones@...hat.com, wei.huang2@....com Subject: Re: [PATCH v4 3/3] selftests: KVM: SVM: Add vmcall test On 06/02/20 23:46, Krish Sadhukhan wrote: >> >> + >> +static inline void l2_vmcall(struct svm_test_data *svm) >> +{ >> + __asm__ __volatile__("vmcall"); > Is it possible to re-use the existing vmcall() function ? Technically the AMD opcode is "vmmcall". Using vmcall() still makes sense as it tests KVM's emulation of the Intel opcode. > Also, we should probably re-name the function to 'l2_guest_code' which > is used in the existing code and also it matches with 'l1_guest_code' > naming. Ok. I also removed the "inline" which is really not used since we take the address of the function. Paolo
Powered by blists - more mailing lists