linux-kernel - Re: [PATCH v2] KVM: x86: remove duplicated KVM_REQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55eb3a20-9660-4155-1e2a-ece8b31dbbfc@redhat.com>
Date:   Wed, 12 Feb 2020 12:45:42 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     linmiaohe <linmiaohe@...wei.com>, rkrcmar@...hat.com,
        sean.j.christopherson@...el.com, vkuznets@...hat.com,
        wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH v2] KVM: x86: remove duplicated KVM_REQ_EVENT request

On 07/02/20 16:27, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@...wei.com>
> 
> The KVM_REQ_EVENT request is already made in kvm_set_rflags(). We should
> not make it again.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> ---
> v1->v2:
> Collected Vitaly's R-b
> ---
>  arch/x86/kvm/x86.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index fbabb2f06273..212282c6fb76 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -8942,7 +8942,6 @@ int kvm_task_switch(struct kvm_vcpu *vcpu, u16 tss_selector, int idt_index,
>  
>  	kvm_rip_write(vcpu, ctxt->eip);
>  	kvm_set_rflags(vcpu, ctxt->eflags);
> -	kvm_make_request(KVM_REQ_EVENT, vcpu);
>  	return 1;
>  }
>  EXPORT_SYMBOL_GPL(kvm_task_switch);
> 

Queued, thanks.

Paolo