linux-kernel - Re: [PATCH 06/10] microblaze: Add sync to tlb operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6585498e-fbcf-6bfe-ef40-b24f5fde7719@xilinx.com>
Date:   Wed, 12 Feb 2020 14:01:49 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Michal Simek <michal.simek@...inx.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michal Simek <monstr@...str.eu>, git@...inx.com,
        Stefan Asserhall <stefan.asserhall@...inx.com>
Subject: Re: [PATCH 06/10] microblaze: Add sync to tlb operations

On 12. 02. 20 14:00, Arnd Bergmann wrote:
> On Wed, Feb 12, 2020 at 9:58 AM Michal Simek <michal.simek@...inx.com> wrote:
>> diff --git a/arch/microblaze/kernel/misc.S b/arch/microblaze/kernel/misc.S
>> index 6759af688451..1228a09d8109 100644
>> --- a/arch/microblaze/kernel/misc.S
>> +++ b/arch/microblaze/kernel/misc.S
>> @@ -39,7 +39,7 @@ _tlbia_1:
>>         rsubi   r11, r12, MICROBLAZE_TLB_SIZE - 1
>>         bneid   r11, _tlbia_1 /* loop for all entries */
>>         addik   r12, r12, 1
>> -       /* sync */
>> +       mbar    1 /* sync */
>>         rtsd    r15, 8
>>         nop
>>         .size  _tlbia, . - _tlbia
> 
> Is there any effect on non-SMP systems?

not - it is just nop.

M