linux-kernel - Re: [External] Re: [PATCH 1/1] usb: Add MA USB Host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200212132222.GD1789899@kroah.com>
Date:   Wed, 12 Feb 2020 05:22:22 -0800
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Vladimir Stankovic <vladimir.stankovic@...playlink.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Petar Kovacevic <petar.kovacevic@...playlink.com>,
        Stefan Lugonjic <stefan.lugonjic@...playlink.com>,
        Nikola Simic <nikola.simic@...playlink.com>,
        Marko Miljkovic <marko.miljkovic@...playlink.com>
Subject: Re: [External] Re: [PATCH 1/1] usb: Add MA USB Host driver

On Wed, Feb 12, 2020 at 09:41:12AM +0000, Vladimir Stankovic wrote:
> On 11.2.20. 17:39, gregkh@...uxfoundation.org wrote:
> > On Tue, Feb 11, 2020 at 04:21:24PM +0000, Vladimir Stankovic wrote:
> >>    39 files changed, 8668 insertions(+)
> > 
> > This is a bit hard, if not impossible, to review all in one huge patch.
> > 
> > Can you resend this as a patch series, breaking it down into logical
> > chunks, like all other kernel patches have?
> > 
> > Also, why so many individual files?  For only 8k lines, 39 files seems
> > like a huge number.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> Will break it down into patch series and resend.
> 
> In regards of the file count, our intention was to ease the 
> troubleshooting efforts during development and have a clear separation 
> between logical parts of MA-USB implementation (i.e data in/out, isoch 
> in/out, etc.; each source file representing logical chunk).

Yeah, but at the very least, only have a single .h "internal" file, you
have whole files for just 1 or 2 function prototypes, that's totally
overkill.

Simple is good, you don't want to have to bounce around through multiple
files for a simple 8k line driver, that's not a good idea.

thanks,

greg k-h