linux-kernel - Re: [PATCH] HID: logitech-dj: add debug msg when exporting a HID++ report descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2002121445030.3144@cbobk.fhfr.pm>
Date:   Wed, 12 Feb 2020 14:45:08 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Filipe Laíns <lains@...hlinux.org>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: logitech-dj: add debug msg when exporting a HID++
 report descriptors

On Mon, 13 Jan 2020, Filipe Laíns wrote:

> When exporting all other types of report descriptors we print a debug
> message. Not doing so for HID++ descriptors makes unaware users think
> that no HID++ descriptor was exported.
> 
> Signed-off-by: Filipe Laíns <lains@...hlinux.org>
> ---
>  drivers/hid/hid-logitech-dj.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index cc7fc71d8b05..8f17a29b5a94 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -1368,6 +1368,8 @@ static int logi_dj_ll_parse(struct hid_device *hid)
>  	}
>  
>  	if (djdev->reports_supported & HIDPP) {
> +		dbg_hid("%s: sending a HID++ descriptor, reports_supported: %llx\n",
> +			__func__, djdev->reports_supported);
>  		rdcat(rdesc, &rsize, hidpp_descriptor,
>  		      sizeof(hidpp_descriptor));

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs