linux-kernel - Re: [PATCH 46/62] x86/sev-es: Handle INVD Events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Feb 2020 16:36:17 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     Andy Lutomirski <luto@...capital.net>
Cc:     x86@...nel.org, hpa@...or.com, Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Hellstrom <thellstrom@...are.com>,
        Jiri Slaby <jslaby@...e.cz>,
        Dan Williams <dan.j.williams@...el.com>,
        Tom Lendacky <Thomas.Lendacky@....com>,
        Juergen Gross <JGross@...e.com>,
        Kees Cook <keescook@...omium.org>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH 46/62] x86/sev-es: Handle INVD Events

On Tue, Feb 11, 2020 at 04:12:19PM -0800, Andy Lutomirski wrote:
> 
> 
> > On Feb 11, 2020, at 5:53 AM, Joerg Roedel <joro@...tes.org> wrote:
> > 
> > From: Tom Lendacky <thomas.lendacky@....com>
> > 
> > Implement a handler for #VC exceptions caused by INVD instructions.
> 
> Uh, what?  Surely the #VC code can have a catch-all OOPS path for things like this. Linux should never ever do INVD.

Right, its hard to come up with a valid use-case for INVD in the Linux
kernel. I changed the patch to mark INVD as unsupported and print an
error message.

Regards,

	Joerg