linux-kernel - Re: [PATCH 5/8] x86,tracing: Mark debug_stack_{set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200212153946.GX14897@hirez.programming.kicks-ass.net>
Date:   Wed, 12 Feb 2020 16:39:46 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        mingo@...nel.org, joel@...lfernandes.org,
        gregkh@...uxfoundation.org, gustavo@...eddedor.com,
        tglx@...utronix.de, paulmck@...nel.org, josh@...htriplett.org,
        mathieu.desnoyers@...icios.com, jiangshanlai@...il.com
Subject: Re: [PATCH 5/8] x86,tracing: Mark debug_stack_{set_zero,reset)()
 notrace

On Wed, Feb 12, 2020 at 10:18:26AM -0500, Steven Rostedt wrote:
> On Wed, 12 Feb 2020 16:04:40 +0100
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > > This entire file is notrace:
> > > 
> > >  arch/x86/kernel/cpu/Makefile:
> > > 
> > >    CFLAGS_REMOVE_common.o = -pg  
> > 
> > Urgh, I hate it that that annotation is so hard to find :/ Also, there
> > seem to be various flavours of that Makefile magic around.
> > 
> >   CFLAGS_REMOVE_lockdep.o = $(CC_FLAGS_FTRACE)
> > 
> > is another variant I encountered.
> 
> Actually, that should be the only variant. That was added for various
> archs, and should be used consistently throughout.
> 
> There's a clean up series for you ;-) (or whoever)

If I'm going to clean this up I'd remove the Makefile rules entirely.
I hate these Makefile rules, they make it entirely non-obvious what is
and is not being traced.