linux-kernel - Re: [PATCH 5.4 85/96] selinux: revert "stop passing MAY_NOT_BLOCK to the AVC upon follow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200213162721.GA3636914@kroah.com>
Date:   Thu, 13 Feb 2020 08:27:21 -0800
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Stephen Smalley <sds@...ho.nsa.gov>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Will Deacon <will@...nel.org>, Paul Moore <paul@...l-moore.com>
Subject: Re: [PATCH 5.4 85/96] selinux: revert "stop passing MAY_NOT_BLOCK to
 the AVC upon follow_link"

On Thu, Feb 13, 2020 at 11:01:41AM -0500, Stephen Smalley wrote:
> On 2/13/20 10:21 AM, Greg Kroah-Hartman wrote:
> > From: Stephen Smalley <sds@...ho.nsa.gov>
> > 
> > commit 1a37079c236d55fb31ebbf4b59945dab8ec8764c upstream.
> > 
> > This reverts commit e46e01eebbbc ("selinux: stop passing MAY_NOT_BLOCK
> > to the AVC upon follow_link"). The correct fix is to instead fall
> > back to ref-walk if audit is required irrespective of the specific
> > audit data type.  This is done in the next commit.
> > 
> > Fixes: e46e01eebbbc ("selinux: stop passing MAY_NOT_BLOCK to the AVC upon follow_link")
> > Reported-by: Will Deacon <will@...nel.org>
> > Signed-off-by: Stephen Smalley <sds@...ho.nsa.gov>
> > Signed-off-by: Paul Moore <paul@...l-moore.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> This patch should be accompanied by commit
> 0188d5c025ca8fe756ba3193bd7d150139af5a88 ("selinux: fall back to ref-walk if
> audit is required").  The former is reverting an incorrect fix for
> bda0be7ad994 ("security: make inode_follow_link RCU-walk aware"), the latter
> is providing the correct fix for it.

Thanks for letting me know, now queued up for both trees.

greg k-h