linux-kernel - Re: [PATCH v4 10/11] mm/damon: Add kunit tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202002140021.Pr9vTFO6%lkp@intel.com>
Date:   Fri, 14 Feb 2020 00:56:50 +0800
From:   kbuild test robot <lkp@...el.com>
To:     sjpark@...zon.com
Cc:     kbuild-all@...ts.01.org, akpm@...ux-foundation.org,
        SeongJae Park <sjpark@...zon.de>, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, amit@...nel.org,
        brendan.d.gregg@...il.com, brendanhiggins@...gle.com, cai@....pw,
        colin.king@...onical.com, corbet@....net, dwmw@...zon.com,
        jolsa@...hat.com, kirill@...temov.name, mark.rutland@....com,
        mgorman@...e.de, minchan@...nel.org, mingo@...hat.com,
        namhyung@...nel.org, peterz@...radead.org, rdunlap@...radead.org,
        rostedt@...dmis.org, sj38.park@...il.com, vdavydov.dev@...il.com,
        linux-mm@...ck.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 10/11] mm/damon: Add kunit tests

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on d5226fa6dbae0569ee43ecfc08bdcd6770fc4755]

url:    https://github.com/0day-ci/linux/commits/sjpark-amazon-com/Introduce-Data-Access-MONitor-DAMON/20200213-003254
base:    d5226fa6dbae0569ee43ecfc08bdcd6770fc4755
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-4) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from mm/damon.c:19:0:
>> include/linux/module.h:131:42: error: redefinition of '__inittest'
     static inline initcall_t __maybe_unused __inittest(void)  \
                                             ^
   include/linux/module.h:124:28: note: in expansion of macro 'module_init'
    #define late_initcall(fn)  module_init(fn)
                               ^~~~~~~~~~~
   include/kunit/test.h:224:2: note: in expansion of macro 'late_initcall'
     late_initcall(kunit_suite_init##suite)
     ^~~~~~~~~~~~~
   mm/damon-test.h:600:1: note: in expansion of macro 'kunit_test_suite'
    kunit_test_suite(damon_test_suite);
    ^~~~~~~~~~~~~~~~
   include/linux/module.h:131:42: note: previous definition of '__inittest' was here
     static inline initcall_t __maybe_unused __inittest(void)  \
                                             ^
   mm/damon.c:1406:1: note: in expansion of macro 'module_init'
    module_init(damon_init);
    ^~~~~~~~~~~
>> include/linux/module.h:133:6: error: redefinition of 'init_module'
     int init_module(void) __copy(initfn) __attribute__((alias(#initfn)));
         ^
   include/linux/module.h:124:28: note: in expansion of macro 'module_init'
    #define late_initcall(fn)  module_init(fn)
                               ^~~~~~~~~~~
   include/kunit/test.h:224:2: note: in expansion of macro 'late_initcall'
     late_initcall(kunit_suite_init##suite)
     ^~~~~~~~~~~~~
   mm/damon-test.h:600:1: note: in expansion of macro 'kunit_test_suite'
    kunit_test_suite(damon_test_suite);
    ^~~~~~~~~~~~~~~~
   include/linux/module.h:133:6: note: previous definition of 'init_module' was here
     int init_module(void) __copy(initfn) __attribute__((alias(#initfn)));
         ^
   mm/damon.c:1406:1: note: in expansion of macro 'module_init'
    module_init(damon_init);
    ^~~~~~~~~~~

vim +/__inittest +131 include/linux/module.h

0fd972a7d91d6e1 Paul Gortmaker 2015-05-01  128  
0fd972a7d91d6e1 Paul Gortmaker 2015-05-01  129  /* Each module must use one module_init(). */
0fd972a7d91d6e1 Paul Gortmaker 2015-05-01  130  #define module_init(initfn)					\
1f318a8bafcfba9 Arnd Bergmann  2017-02-01 @131  	static inline initcall_t __maybe_unused __inittest(void)		\
0fd972a7d91d6e1 Paul Gortmaker 2015-05-01  132  	{ return initfn; }					\
a6e60d84989fa0e Miguel Ojeda   2019-01-19 @133  	int init_module(void) __copy(initfn) __attribute__((alias(#initfn)));
0fd972a7d91d6e1 Paul Gortmaker 2015-05-01  134  

:::::: The code at line 131 was first introduced by commit
:::::: 1f318a8bafcfba9f0d623f4870c4e890fd22e659 modules: mark __inittest/__exittest as __maybe_unused

:::::: TO: Arnd Bergmann <arnd@...db.de>
:::::: CC: Jessica Yu <jeyu@...hat.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (71807 bytes)