| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <77c9dd91-8f51-499b-3b1a-f5966f2ed35d@gmail.com>
Date: Thu, 13 Feb 2020 19:17:30 +0100
From: Matthias Brugger <matthias.bgg@...il.com>
To: CK Hu <ck.hu@...iatek.com>, matthias.bgg@...nel.org
Cc: mark.rutland@....com, rdunlap@...radead.org, airlied@...ux.ie,
mturquette@...libre.com, dri-devel@...ts.freedesktop.org,
laurent.pinchart@...asonboard.com, ulrich.hecht+renesas@...il.com,
linux-clk@...r.kernel.org, drinkcat@...omium.org, wens@...e.org,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
frank-w@...lic-files.de, sean.wang@...iatek.com,
robh+dt@...nel.org, linux-mediatek@...ts.infradead.org,
hsinyi@...omium.org, linux-arm-kernel@...ts.infradead.org,
mbrugger@...e.com, sboyd@...nel.org, sean.wang@...nel.org,
linux-kernel@...r.kernel.org, p.zabel@...gutronix.de,
enric.balletbo@...labora.com
Subject: Re: [resend PATCH v6 01/12] dt-bindings: display: mediatek: Add mmsys
binding description
On 09/12/2019 06:12, CK Hu wrote:
> Hi, Matthias:
>
> On Sat, 2019-12-07 at 23:47 +0100, matthias.bgg@...nel.org wrote:
>> From: Matthias Brugger <mbrugger@...e.com>
>>
>> The MediaTek DRM has a block called mmsys, which sets
>> the routing and enalbes the different blocks.
>> This patch adds one line for the mmsys bindings description.
>>
>> Signed-off-by: Matthias Brugger <mbrugger@...e.com>
>> ---
>> .../display/mediatek/mediatek,disp.txt | 28 ++++++++++---------
>> 1 file changed, 15 insertions(+), 13 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
>> index 8469de510001..c71c8a4b73ff 100644
>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
>> @@ -27,20 +27,22 @@ Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt.
>>
>> Required properties (all function blocks):
>> - compatible: "mediatek,<chip>-disp-<function>", one of
>> - "mediatek,<chip>-disp-ovl" - overlay (4 layers, blending, csc)
>> - "mediatek,<chip>-disp-rdma" - read DMA / line buffer
>> - "mediatek,<chip>-disp-wdma" - write DMA
>> - "mediatek,<chip>-disp-color" - color processor
>> - "mediatek,<chip>-disp-aal" - adaptive ambient light controller
>> - "mediatek,<chip>-disp-gamma" - gamma correction
>> - "mediatek,<chip>-disp-merge" - merge streams from two RDMA sources
>> - "mediatek,<chip>-disp-split" - split stream to two encoders
>> - "mediatek,<chip>-disp-ufoe" - data compression engine
>> - "mediatek,<chip>-dsi" - DSI controller, see mediatek,dsi.txt
>> - "mediatek,<chip>-dpi" - DPI controller, see mediatek,dpi.txt
>> - "mediatek,<chip>-disp-mutex" - display mutex
>> - "mediatek,<chip>-disp-od" - overdrive
>> + "mediatek,<chip>-disp-ovl" - overlay (4 layers, blending, csc)
>
> This patch conflicts with 5.5-rc, please resend this patch base on
> 5.5-rc1.
>
>> + "mediatek,<chip>-disp-rdma" - read DMA / line buffer
>> + "mediatek,<chip>-disp-wdma" - write DMA
>> + "mediatek,<chip>-disp-color" - color processor
>> + "mediatek,<chip>-disp-aal" - adaptive ambient light controller
>> + "mediatek,<chip>-disp-gamma" - gamma correction
>> + "mediatek,<chip>-disp-merge" - merge streams from two RDMA sources
>> + "mediatek,<chip>-disp-split" - split stream to two encoders
>> + "mediatek,<chip>-disp-ufoe" - data compression engine
>> + "mediatek,<chip>-dsi" - DSI controller, see mediatek,dsi.txt
>> + "mediatek,<chip>-dpi" - DPI controller, see mediatek,dpi.txt
>> + "mediatek,<chip>-disp-mutex" - display mutex
>> + "mediatek,<chip>-disp-od" - overdrive
>> + "mediatek,<chip>-mmsys", "syscon" - provide clocks and components management
>> the supported chips are mt2701, mt2712 and mt8173.
>
> The original binding document for mmsys is in [1], I think we should not
> define it in duplicate. Maybe you could remove the original document.
>
> [1]
> https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/mediatek/mediatek%2Cmmsys.txt
I think we should keep it, as it describes some requirements that are otherwise
lost. I'll adapt the mmsys description and add a hint to it, like we do for dsi
and dpi.
Regards,
Matthias
>
> Regards,
> CK
>
>> +
>> - reg: Physical base address and length of the function block register space
>> - interrupts: The interrupt signal from the function block (required, except for
>> merge and split function blocks).
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
Powered by blists - more mailing lists