linux-kernel - Re: [PATCH] KVM: x86: eliminate some unreachable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac51e889-624a-b108-d03c-4dc3e91c9a69@oracle.com>
Date:   Thu, 13 Feb 2020 10:53:34 -0800
From:   Krish Sadhukhan <krish.sadhukhan@...cle.com>
To:     linmiaohe <linmiaohe@...wei.com>, pbonzini@...hat.com,
        rkrcmar@...hat.com, sean.j.christopherson@...el.com,
        vkuznets@...hat.com, wanpengli@...cent.com, jmattson@...gle.com,
        joro@...tes.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, hpa@...or.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] KVM: x86: eliminate some unreachable code


On 2/12/20 6:53 PM, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@...wei.com>
>
> These code are unreachable, remove them.
>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>   arch/x86/kvm/vmx/vmx.c | 1 -
>   arch/x86/kvm/x86.c     | 3 ---
>   2 files changed, 4 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index bb5c33440af8..b6d4eafe01cf 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -4505,7 +4505,6 @@ static bool rmode_exception(struct kvm_vcpu *vcpu, int vec)
>   	case GP_VECTOR:
>   	case MF_VECTOR:
>   		return true;
> -	break;
>   	}
>   	return false;
>   }
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index fbabb2f06273..a597009aefd7 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3081,7 +3081,6 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>   		break;
>   	case APIC_BASE_MSR ... APIC_BASE_MSR + 0x3ff:
>   		return kvm_x2apic_msr_read(vcpu, msr_info->index, &msr_info->data);
> -		break;
>   	case MSR_IA32_TSCDEADLINE:
>   		msr_info->data = kvm_get_lapic_tscdeadline_msr(vcpu);
>   		break;
> @@ -3164,7 +3163,6 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>   		return kvm_hv_get_msr_common(vcpu,
>   					     msr_info->index, &msr_info->data,
>   					     msr_info->host_initiated);
> -		break;
>   	case MSR_IA32_BBL_CR_CTL3:
>   		/* This legacy MSR exists but isn't fully documented in current
>   		 * silicon.  It is however accessed by winxp in very narrow
> @@ -8471,7 +8469,6 @@ static inline int vcpu_block(struct kvm *kvm, struct kvm_vcpu *vcpu)
>   		break;
>   	default:
>   		return -EINTR;
> -		break;
>   	}
>   	return 1;
>   }
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@...cle.com>