linux-kernel - Re: Regression: hibernation is broken since e6bc9de714972cac34daa1dc1567ee48a47a9342

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200213193410.GB6868@magnolia>
Date:   Thu, 13 Feb 2020 11:34:10 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Christoph Hellwig <hch@....de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Regression: hibernation is broken since
 e6bc9de714972cac34daa1dc1567ee48a47a9342

On Thu, Feb 13, 2020 at 07:35:15PM +0100, Domenico Andreoli wrote:
> On Thu, Feb 13, 2020 at 09:57:53AM -0800, Darrick J. Wong wrote:
> > On Thu, Feb 13, 2020 at 06:23:51PM +0100, Domenico Andreoli wrote:
> > > Hi,
> > > 
> > >   at some point between 5.2 and 5.3 my laptop started to refuse
> > > hibernating and come back to a full functional state. It's fully 100%
> > > reproducible, no oopses or any other damage to the state seems to happen.
> > > 
> > > It took me a while to follow the trail down to this commit. If I revert
> > > it from v5.6-rc1, the hibernation is back as in the old times.
> > 
> > Hmm, do you know which hibernation mechanism your computer is using?
> > 
> > --D
> 
> s2disk/uswsusp. Any other tool I could use as alternative?

Well ... you could try the in-kernel hibernate (which I think is what
'systemctl hibernate' does), though you'd lose the nifty features of
µswsusp.

In the end, though, I'll probably have to revert all those IS_SWAPFILE
checks (at least if CONFIG_HIBERNATION=y) since it's not fair to force
you to totally reconfigure your hibernation setup.

--D

> Thanks,
> Domenico
> 
> -- 
> rsa4096: 3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13
> ed25519: FFB4 0CC3 7F2E 091D F7DA  356E CC79 2832 ED38 CB05