linux-kernel - Re: [RESEND v5 2/2] pwm: core: Convert period and duty cycle to u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200213193926.GA20183@codeaurora.org>
Date:   Thu, 13 Feb 2020 11:39:26 -0800
From:   Guru Das Srinagesh <gurus@...eaurora.org>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     linux-pwm@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        Subbaraman Narayanamurthy <subbaram@...eaurora.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND v5 2/2] pwm: core: Convert period and duty cycle to u64

On Thu, Feb 13, 2020 at 11:18:02AM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Feb 12, 2020 at 10:54:08AM -0800, Guru Das Srinagesh wrote:
> > @@ -305,8 +305,8 @@ struct pwm_chip {
> >   * @duty_cycle: duty cycle of the PWM signal (in nanoseconds)
> >   */
> >  struct pwm_capture {
> > -	unsigned int period;
> > -	unsigned int duty_cycle;
> > +	u64 period;
> > +	u64 duty_cycle;
> >  };
> 
> Is this last hunk a separate change?
> 
> Otherwise looks fine.

Hi Uwe,

No, this is very much a part of the change and not a separate one.

If things look good to you, could you please add an Acked-by or
Reviewed-by tag to the patches so that they get accepted by Thierry?

Thank you.

Guru Das.