linux-kernel - Re: [tip: core/objtool] objtool: Fail the kernel build on fatal errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200213221100.odwg5gan3dwcpk6g@treble>
Date:   Thu, 13 Feb 2020 16:11:00 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     tip-bot2 for Josh Poimboeuf <tip-bot2@...utronix.de>
Cc:     linux-tip-commits@...r.kernel.org, Borislav Petkov <bp@...e.de>,
        Julien Thierry <jthierry@...hat.com>, x86 <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [tip: core/objtool] objtool: Fail the kernel build on fatal
 errors

On Tue, Feb 11, 2020 at 12:47:38PM -0000, tip-bot2 for Josh Poimboeuf wrote:
> The following commit has been merged into the core/objtool branch of tip:
> 
> Commit-ID:     644592d328370af4b3e027b7b1ae9f81613782d8
> Gitweb:        https://git.kernel.org/tip/644592d328370af4b3e027b7b1ae9f81613782d8
> Author:        Josh Poimboeuf <jpoimboe@...hat.com>
> AuthorDate:    Mon, 10 Feb 2020 12:32:38 -06:00
> Committer:     Borislav Petkov <bp@...e.de>
> CommitterDate: Tue, 11 Feb 2020 13:27:03 +01:00
> 
> objtool: Fail the kernel build on fatal errors
> 
> When objtool encounters a fatal error, it usually means the binary is
> corrupt or otherwise broken in some way.  Up until now, such errors were
> just treated as warnings which didn't fail the kernel build.
> 
> However, objtool is now stable enough that if a fatal error is
> discovered, it most likely means something is seriously wrong and it
> should fail the kernel build.
> 
> Note that this doesn't apply to "normal" objtool warnings; only fatal
> ones.

Clang still has some toolchain issues which need to be sorted out, so
upgrading the fatal errors is causing their CI to fail.

So I think we need to drop this one for now.

Boris, are you able to just drop it or should I send a revert?

-- 
Josh