linux-kernel - Re: linux-next: Fixes tag needs some work in the hid tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05403763-3849-06ec-870e-c7e9c907714d@cisco.com>
Date:   Thu, 13 Feb 2020 06:28:52 +0000
From:   "Johan Korsnes (jkorsnes)" <jkorsnes@...co.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
CC:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the hid tree

On 2/12/20 9:49 PM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5ebdffd25098 ("HID: core: fix off-by-one memset in hid_report_raw_event()")
> 
> Fixes tag
> 
>   Fixes: 966922f26c7f ("HID: fix a crash in hid_report_raw_event()
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.
>

Sorry about this. The checkpatch.pl script initially did complain
about the format of my commit references in v1:

"ERROR: Please use git commit description style"

But it only complained about number of characters in SHA, it did not
mention anything about line break. I will take care not to introduce
these line breaks in future commits, but it would be nice if
checkpatch.pl could check for this.

Johan