linux-kernel - Re: [PATCH] asm-generic/bitops: Update stale comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Feb 2020 11:47:26 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Will Deacon <will@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stefana@...inx.com
Subject: Re: [PATCH] asm-generic/bitops: Update stale comment

On Thu, Feb 13, 2020 at 09:39:27AM +0000, Will Deacon wrote:
> The comment in 'asm-generic/bitops.h' states that you should "recode
> these in the native assembly language, if at all possible". This is
> pretty crappy advice now that the generic implementation is defined in
> terms of atomic_long_t rather than a spinlock, so update the comment and
> hopefully save future architecture maintainers a bit of work.
> 
> Cc: Peter Zijlstra <peterz@...radead.org>
> Reported-by: Stefan Asserhall <stefana@...inx.com>
> Signed-off-by: Will Deacon <will@...nel.org>

Thanks Will!