linux-kernel - Re: [PATCH v3 0/4] EDAC/mc: Fixes for mci device removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200213110512.GH31799@zn.tnic>
Date:   Thu, 13 Feb 2020 12:05:12 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Robert Richter <rrichter@...vell.com>,
        John Garry <john.garry@...wei.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Aristeu Rozanski <aris@...hat.com>, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/4] EDAC/mc: Fixes for mci device removal

On Wed, Feb 12, 2020 at 01:03:36PM +0100, Robert Richter wrote:
> This series is a split of
> 
>  [v2] EDAC/mc: Fix use-after-free and memleaks during device removal
>  https://lore.kernel.org/patchwork/patch/1190002/
> 
> in smaller patches to better handle stable backports.
> 
> Patch #1 helps to ease backports of patch #2 to 5.3 and earlier
> kernels, see patch descriptions of both for details.
> 
> Patch #2 is the smallest possible fix to address use-after-free and
> memleak issues aimed for backports.
> 
> Patch #3 is another small patch that is split off for stable. This
> fixes code already commited to stable trees.
> 
> Patch #4 is the all remaining code containing the rework of the mci
> device removal. Resulting code is the same as in v2 except for the
> changes outlined for v3:
> 
> v3:
>  * split patch into smaller pieces to ease backports,
>  * removed edac_remove_sysfs_mci_device() in edac_mc_free(), at this
>    point the mci device is always unregistered
> 
> Robert Richter (4):
>   Revert parts of "EDAC/mc_sysfs: Make debug messages consistent"
>   EDAC/mc: Fix use-after-free and memleaks during device removal
>   EDAC/sysfs: Remove csrow objects on errors
>   EDAC/mc: Change mci device removal to use put_device()
> 
>  drivers/edac/edac_mc.c       |  20 +++----
>  drivers/edac/edac_mc_sysfs.c | 100 +++++++++++++----------------------
>  drivers/edac/edac_module.h   |   1 -
>  3 files changed, 48 insertions(+), 73 deletions(-)

Thanks, first three (1+2 squashed) pushed here:

https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git/log/?h=edac-urgent

@John: if you could run them one more time on your machines, that would
be great!

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette