[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200212204128.20f5e8ba@oasis.local.home>
Date: Wed, 12 Feb 2020 20:41:28 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Joel Fernandes <joel@...lfernandes.org>
Cc: Peter Zijlstra <peterz@...radead.org>,
linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
mingo@...nel.org, gregkh@...uxfoundation.org,
gustavo@...eddedor.com, tglx@...utronix.de, paulmck@...nel.org,
josh@...htriplett.org, mathieu.desnoyers@...icios.com,
jiangshanlai@...il.com
Subject: Re: [PATCH v2 2/9] rcu: Mark rcu_dynticks_curr_cpu_in_eqs() inline
On Wed, 12 Feb 2020 17:38:18 -0500
Joel Fernandes <joel@...lfernandes.org> wrote:
> I think there are ways to turn off function inlining, such as gcc's:
> -fkeep-inline-functions
>
> And just to be sure weird compilers (clang *cough*) don't screw this up,
> could we make it static inline notrace?
inline is defined as notrace, so not needed.
I did that because of surprises when functions marked as inline
suddenly became non inlined and traced, which caused issues with
function tracing (before I finally got recursion protection working).
But even then, I figured, if something is inlined and gcc actually
inlines it, it wont be traced. For consistency, if something is marked
inline, it should not be traced.
-- Steve
Powered by blists - more mailing lists