linux-kernel - Re: [PATCH AUTOSEL 5.5 408/542] drm/amdgpu: add the lost mutex_init back

Open Source and information security mailing list archives

Message-ID: <CADnq5_MMLNtb=3LLHsYnXtONQf4NWNgV226w2=OFk3JpCRj3sA@mail.gmail.com>
Date:   Fri, 14 Feb 2020 11:22:27 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Sasha Levin <sashal@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "for 3.8" <stable@...r.kernel.org>, Feifei Xu <Feifei.Xu@....com>,
        xinhui pan <xinhui.pan@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH AUTOSEL 5.5 408/542] drm/amdgpu: add the lost mutex_init back

On Fri, Feb 14, 2020 at 10:57 AM Sasha Levin <sashal@...nel.org> wrote:
>
> From: "Pan, Xinhui" <Xinhui.Pan@....com>
>
> [ Upstream commit bd0522112332663e386df1b8642052463ea9b3b9 ]
>
> Initialize notifier_lock.
>
> Bug: https://gitlab.freedesktop.org/drm/amd/issues/1016
> Reviewed-by: Feifei Xu <Feifei.Xu@....com>
> Reviewed-by: Christian König <christian.koenig@....com>
> Signed-off-by: xinhui pan <xinhui.pan@....com>
> Signed-off-by: Alex Deucher <alexander.deucher@....com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 332b9c24a2cd0..a2f788ad7e1c6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2797,6 +2797,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,
>         mutex_init(&adev->notifier_lock);
>         mutex_init(&adev->virt.dpm_mutex);
>         mutex_init(&adev->psp.mutex);
> +       mutex_init(&adev->notifier_lock);
>

This patch is not relevant here.  The same mutex is already
initialized 3 lines above.

Alex

>         r = amdgpu_device_check_arguments(adev);
>         if (r)
> --
> 2.20.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives