linux-kernel - Re: [PATCH v5] media: dvb_dummy_tuner: implement driver skeleton

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200214050813.GA37036@ubuntu-m2-xlarge-x86>
Date:   Thu, 13 Feb 2020 22:08:13 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
Cc:     mchehab@...nel.org, sean@...s.org, tglx@...utronix.de,
        gregkh@...uxfoundation.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
        linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v5] media: dvb_dummy_tuner: implement driver skeleton

Hi Daniel,

On Mon, Feb 10, 2020 at 12:41:02PM -0300, Daniel W. S. Almeida wrote:
> From: "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
> 
> The virtual DVB test driver serves as a reference DVB driver and helps
> validate the existing APIs in the media subsystem. It can also aid developers
> working on userspace applications.
> 
> This dummy tuner should support common TV standards such as DVB-T/T2/S/S2,
> ISDB-T and ATSC when completed.
> 
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@...il.com>

This patch and another one that you have [1] cause a ton of build
warnings with clang, as reported by the 0day bot, because of the
implicit conversions from floating points to integer. Is this
intentional? Would you mind taking a look at them and addressing them if
you do another revision?

You can view the reports here:

https://groups.google.com/d/msg/clang-built-linux/54FdauqEgTY/EjYzpdgxBgAJ
https://groups.google.com/d/msg/clang-built-linux/VY02Ju2AHrk/Hu8lxhdCBgAJ

[1]: https://lore.kernel.org/lkml/20200210154555.156283-1-dwlsalmeida@gmail.com/

Cheers,
Nathan