linux-kernel - Re: [PATCH v7 bpf-next RESEND 1/2] bpf: Add bpf_read_branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Feb 2020 22:34:56 -0800
From:   "Daniel Xu" <dxu@...uu.xyz>
To:     "Andrii Nakryiko" <andrii.nakryiko@...il.com>
Cc:     "bpf" <bpf@...r.kernel.org>, "Alexei Starovoitov" <ast@...nel.org>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        "Song Liu" <songliubraving@...com>, "Yonghong Song" <yhs@...com>,
        "Andrii Nakryiko" <andriin@...com>,
        "open list" <linux-kernel@...r.kernel.org>,
        "Kernel Team" <kernel-team@...com>,
        "Peter Ziljstra" <peterz@...radead.org>,
        "Ingo Molnar" <mingo@...hat.com>,
        "Arnaldo Carvalho de Melo" <acme@...nel.org>
Subject: Re: [PATCH v7 bpf-next RESEND 1/2] bpf: Add
 bpf_read_branch_records() helper

On Tue Feb 11, 2020 at 11:23 AM, Andrii Nakryiko wrote:
> On Mon, Feb 10, 2020 at 12:09 PM Daniel Xu <dxu@...uu.xyz> wrote:
[...]
> > + * int bpf_read_branch_records(struct bpf_perf_event_data *ctx, void *buf, u32 size, u64 flags)
> > + *     Description
> > + *             For an eBPF program attached to a perf event, retrieve the
> > + *             branch records (struct perf_branch_entry) associated to *ctx*
> > + *             and store it in the buffer pointed by *buf* up to size
> > + *             *buf_size* bytes.
> > + *     Return
> > + *             On success, number of bytes written to *buf*. On error, a
> > + *             negative value.
> > + *
> > + *             The *flags* can be set to **BPF_F_GET_BRANCH_RECORDS_SIZE** to
> > + *             instead return the number of bytes required to store all the
> > + *             branch entries. If this flag is set, *buf* may be NULL.
> > + *
> > + *             **-EINVAL** if arguments invalid or **buf_size** not a multiple
>
> 
> buf_size -> size

Whoops, thanks for catching.

[...]