linux-kernel - Re: [PATCH v2 01/12] drm: ingenic-drm: add MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1581707177.3.6@crapouillou.net>
Date:   Fri, 14 Feb 2020 16:06:17 -0300
From:   Paul Cercueil <paul@...pouillou.net>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Paul Boddie <paul@...die.org.uk>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Andi Kleen <ak@...ux.intel.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Kees Cook <keescook@...omium.org>, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com
Subject: Re: [PATCH v2 01/12] drm: ingenic-drm: add MODULE_DEVICE_TABLE

Hi Nikolaus,

Please rebase this patch on top of drm-misc-next and send it apart - it 
should go through the DRM tree.


Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller 
<hns@...delico.com> a écrit :
> Add MODULE_DEVICE_TABLE so that the driver can load by
> matching the device tree if compiled as module.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> ---
>  drivers/gpu/drm/ingenic/ingenic-drm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c 
> b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index 6d47ef7b148c..d8617096dd8e 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -844,6 +844,8 @@ static const struct of_device_id 
> ingenic_drm_of_match[] = {
>  	{ /* sentinel */ },
>  };
> 
> +MODULE_DEVICE_TABLE(of, ingenic_drm_of_match);

Also please remove the blank line above MODULE_DEVICE_TABLE.

Cheers,
-Paul

> +
>  static struct platform_driver ingenic_drm_driver = {
>  	.driver = {
>  		.name = "ingenic-drm",
> --
> 2.23.0
>