lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 14 Feb 2020 16:13:53 -0300
From:   Paul Cercueil <paul@...pouillou.net>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Paul Boddie <paul@...die.org.uk>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Andi Kleen <ak@...ux.intel.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Kees Cook <keescook@...omium.org>, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com
Subject: Re: [PATCH v2 12/12] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC

Hi Nikolaus,


Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller 
<hns@...delico.com> a écrit :
> Interrupts should not be specified by interrupt line but by
> gpio parent and reference.
> 
> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes")

If you add a Fixes tag, you should also add:
Cc: stable@...r.kernel.org

if you're fixing something older than -rc1, which is the case here 
(alternatively Cc them manually, but just for these patches).

Same remark for your patch 05/12.

Cheers,
-Paul

> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> ---
>  arch/mips/boot/dts/ingenic/ci20.dts | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts 
> b/arch/mips/boot/dts/ingenic/ci20.dts
> index 8f9d182566db..4bacefa2cfce 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -298,7 +298,9 @@ Optional input supply properties:
>  		rtc@51 {
>  			compatible = "nxp,pcf8563";
>  			reg = <0x51>;
> -			interrupts = <110>;
> +
> +			interrupt-parent = <&gpf>;
> +			interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
>  		};
>  };
> 
> --
> 2.23.0
> 


Powered by blists - more mailing lists