lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Feb 2020 11:31:43 -0800 From: Minchan Kim <minchan@...nel.org> To: Jens Axboe <axboe@...nel.dk> Cc: Jann Horn <jannh@...gle.com>, io-uring <io-uring@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>, Linux API <linux-api@...r.kernel.org>, Oleksandr Natalenko <oleksandr@...hat.com>, Suren Baghdasaryan <surenb@...gle.com>, Tim Murray <timmurray@...gle.com>, Daniel Colascione <dancol@...gle.com>, Sandeep Patil <sspatil@...gle.com>, Sonny Rao <sonnyrao@...gle.com>, Brian Geffon <bgeffon@...gle.com>, Michal Hocko <mhocko@...e.com>, Johannes Weiner <hannes@...xchg.org>, Shakeel Butt <shakeelb@...gle.com>, John Dias <joaodias@...gle.com>, Joel Fernandes <joel@...lfernandes.org>, sj38.park@...il.com, Alexander Duyck <alexander.h.duyck@...ux.intel.com> Subject: Re: [PATCH v5 1/7] mm: pass task and mm to do_madvise On Fri, Feb 14, 2020 at 12:09:50PM -0700, Jens Axboe wrote: > On 2/14/20 11:45 AM, Minchan Kim wrote: > > diff --git a/fs/io_uring.c b/fs/io_uring.c > > index 63beda9bafc5..1c7e9cd6c8ce 100644 > > --- a/fs/io_uring.c > > +++ b/fs/io_uring.c > > @@ -2736,7 +2736,7 @@ static int io_madvise(struct io_kiocb *req, struct io_kiocb **nxt, > > if (force_nonblock) > > return -EAGAIN; > > > > - ret = do_madvise(ma->addr, ma->len, ma->advice); > > + ret = do_madvise(NULL, current->mm, ma->addr, ma->len, ma->advice); > > if (ret < 0) > > req_set_fail_links(req); > > io_cqring_add_event(req, ret); > > I think we want to use req->work.mm here - it'll be the same as > current->mm at this point, but it makes it clear that we're using a > grabbed mm. Will fix at respin. Thanks for the review!
Powered by blists - more mailing lists