linux-kernel - [PATCH 26/30] tipc: Add missing annotation for tipc_node_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200214204741.94112-27-jbi.octave@gmail.com>
Date:   Fri, 14 Feb 2020 20:47:37 +0000
From:   Jules Irenge <jbi.octave@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     boqun.feng@...il.com, Jules Irenge <jbi.octave@...il.com>,
        Jon Maloy <jmaloy@...hat.com>,
        Ying Xue <ying.xue@...driver.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev@...r.kernel.org (open list:TIPC NETWORK LAYER),
        tipc-discussion@...ts.sourceforge.net (open list:TIPC NETWORK LAYER)
Subject: [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock()

Sparse reports a warning at tipc_node_write_lock()

warning: context imbalance in  tipc_node_write_lock - wrong count at exit

The root cause is the missing annotation at tipc_node_write_lock()
Add the missing __acquires(&n->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@...il.com>
---
 net/tipc/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/node.c b/net/tipc/node.c
index eafa38896e3a..d8401789fa23 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -361,7 +361,7 @@ static void tipc_node_read_unlock(struct tipc_node *n) __releases(&n->lock)
 	read_unlock_bh(&n->lock);
 }
 
-static void tipc_node_write_lock(struct tipc_node *n)
+static void tipc_node_write_lock(struct tipc_node *n) __acquires(&n->lock)
 {
 	write_lock_bh(&n->lock);
 }
-- 
2.24.1