lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Feb 2020 05:02:29 +0800 From: Haiwei Li <lihaiwei.kernel@...il.com> To: "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Cc: "pbonzini@...hat.com" <pbonzini@...hat.com> Subject: [PATCH] KVM: Add the check and free to avoid unknown errors. From: Haiwei Li <lihaiwei@...cent.com> If 'kvm_create_vm_debugfs()' fails in 'kzalloc(sizeof(*stat_data), ...)', 'kvm_destroy_vm_debugfs()' will be called by the final fput(file) in 'kvm_dev_ioctl_create_vm()'. Add the check and free to avoid unknown errors. Signed-off-by: Haiwei Li <lihaiwei@...cent.com> --- virt/kvm/kvm_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 67ae2d5..18a32e1 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -617,8 +617,11 @@ static void kvm_destroy_vm_debugfs(struct kvm *kvm) debugfs_remove_recursive(kvm->debugfs_dentry); if (kvm->debugfs_stat_data) { - for (i = 0; i < kvm_debugfs_num_entries; i++) + for (i = 0; i < kvm_debugfs_num_entries; i++) { + if (!kvm->debugfs_stat_data[i]) + break; kfree(kvm->debugfs_stat_data[i]); + } kfree(kvm->debugfs_stat_data); } } -- 1.8.3.1
Powered by blists - more mailing lists