linux-kernel - Re: [PATCH for 4.19-stable] padata: fix null pointer deref of pd->pinst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200214211718.GD4087988@kroah.com>
Date:   Fri, 14 Feb 2020 16:17:18 -0500
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Daniel Jordan <daniel.m.jordan@...cle.com>
Cc:     Sasha Levin <sashal@...nel.org>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH for 4.19-stable] padata: fix null pointer deref of
 pd->pinst

On Fri, Feb 14, 2020 at 01:28:21PM -0500, Daniel Jordan wrote:
> The 4.19 backport dc34710a7aba ("padata: Remove broken queue flushing")
> removed padata_alloc_pd()'s assignment to pd->pinst, resulting in:
> 
>     Unable to handle kernel NULL pointer dereference ...
>     ...
>     pc : padata_reorder+0x144/0x2e0
>     ...
>     Call trace:
>      padata_reorder+0x144/0x2e0
>      padata_do_serial+0xc8/0x128
>      pcrypt_aead_enc+0x60/0x70 [pcrypt]
>      padata_parallel_worker+0xd8/0x138
>      process_one_work+0x1bc/0x4b8
>      worker_thread+0x164/0x580
>      kthread+0x134/0x138
>      ret_from_fork+0x10/0x18
> 
> This happened because the backport was based on an enhancement that
> moved this assignment but isn't in 4.19:
> 
>   bfde23ce200e ("padata: unbind parallel jobs from specific CPUs")
> 
> Simply restore the assignment to fix the crash.
> 
> Fixes: dc34710a7aba ("padata: Remove broken queue flushing")
> Reported-by: Yang Yingliang <yangyingliang@...wei.com>
> Signed-off-by: Daniel Jordan <daniel.m.jordan@...cle.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Sasha Levin <sashal@...nel.org>
> Cc: Steffen Klassert <steffen.klassert@...unet.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: stable@...r.kernel.org
> ---
>  kernel/padata.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks for this, now queued up.

greg k-h