lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 14 Feb 2020 13:47:37 -0800
From:   Daniel Rosenberg <>
To:     Eric Biggers <>,
        Gabriel Krisman Bertazi <>
Cc:     "Theodore Ts'o" <>,,
        Jaegeuk Kim <>, Chao Yu <>,,,
        Alexander Viro <>,
        Richard Weinberger <>,,
        Andreas Dilger <>,
        Jonathan Corbet <>,,,,
Subject: Re: [PATCH v7 1/8] unicode: Add utf8_casefold_iter

On Tue, Feb 11, 2020 at 7:38 PM Eric Biggers <> wrote:
> Indirect function calls are expensive these days for various reasons, including
> Spectre mitigations and CFI.  Are you sure it's okay from a performance
> perspective to make an indirect call for every byte of the pathname?
> > +typedef int (*utf8_itr_actor_t)(struct utf8_itr_context *, int byte, int pos);
> The byte argument probably should be 'u8', to avoid confusion about whether it's
> a byte or a Unicode codepoint.
> - Eric

Gabriel, what do you think here? I could change it to either exposing
the things necessary to do the hashing in libfs, or instead of the
general purpose iterator, just have a hash function inside of unicode
that will compute the hash given a seed value.

Powered by blists - more mailing lists