lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 14 Feb 2020 15:12:28 -0800
From:   Eric Dumazet <>
To:     Shakeel Butt <>
Cc:     Johannes Weiner <>, Tejun Heo <>,
        Greg Thelen <>,
        Michal Hocko <>,
        Vladimir Davydov <>,
        Andrew Morton <>,
        Cgroups <>, linux-mm <>,
        Roman Gushchin <>,
        LKML <>
Subject: Re: [PATCH v2] cgroup: memcg: net: do not associate sock with
 unrelated cgroup

On Fri, Feb 14, 2020 at 2:48 PM Shakeel Butt <> wrote:

> I think in the current code if the association is skipped at
> allocation time then the sock will remain unassociated for its
> lifetime.
> Maybe we can add the association in the later stages but it seems like
> it is not a simple task i.e. edbe69ef2c90f ("Revert "defer call to
> mem_cgroup_sk_alloc()"").

Half TCP sockets are passive, so this means that 50% of TCP sockets
won't be charged.
(the socket cloning always happens from BH context)

I think this deserves a comment in the changelog or documentation,
otherwise some people might think
using memcg will make them safe.

Powered by blists - more mailing lists