[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdawYjK9ma6pHnZYoHgsMxgfB1PbNCA83aD3Z-KS0CVAMw@mail.gmail.com>
Date: Fri, 14 Feb 2020 08:57:53 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Shreyas Joshi <shreyas.joshi@...mp.com>
Cc: Lee Jones <lee.jones@...aro.org>,
Support Opensource <Support.Opensource@...semi.com>,
shreyasjoshi15@...il.com,
Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V4] mfd: da9062: add support for interrupt polarity
defined in device tree
Hi Shreyas,
thanks for your patch!
On Thu, Feb 13, 2020 at 6:40 AM Shreyas Joshi <shreyas.joshi@...mp.com> wrote:
> + switch (*trigger) {
> + case IRQ_TYPE_LEVEL_HIGH:
> + irq_type = 1;
> + break;
> + case IRQ_TYPE_LEVEL_LOW:
> + irq_type = 0;
> + break;
Please create #defines for the level indicator, like
#define DA9062_IRQ_HIGH 1
#define DA9062_IRQ_LOW 0
and use that.
With that change:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Yours,
Linus Walleij
Powered by blists - more mailing lists